-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore docstrings in ssl
#126890
Comments
Related: #113160 (comment) cpython/Tools/clinic/libclinic/parse_args.py Lines 309 to 311 in 2313f84
|
All of them, unless there's some specific reason not to. And even if then, they could be restored as comments. |
Yeah, but I don't know how many docstrings there were originally yet. |
@ZeroIntensity, are you still planning to add these back?
Nineteen or so:
|
I am! Sorry for the delay, I've gotten sidetracked with some other issues. I'll have plenty of time today to get this done. |
…27281) (cherry picked from commit c112de1) Co-authored-by: Peter Bierma <[email protected]>
) (cherry picked from commit c112de1) Co-authored-by: Peter Bierma <[email protected]>
Bug report
Bug description:
As mentioned here, apparently I stripped some of the docstrings while switching things over to argument clinic in the big SSL thread safety fix (GH-124993).
I'm not certain how much needs to be restored, but I'll get to fixing this sometime this weekend or next week.
cc @JelleZijlstra, @neonene
CPython versions tested on:
3.14, CPython main branch
Operating systems tested on:
No response
Linked PRs
ssl
docstrings #127281ssl
docstrings (GH-127281) #127513The text was updated successfully, but these errors were encountered: