Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static copyright years #126133

Open
hugovk opened this issue Oct 29, 2024 · 6 comments · May be fixed by #126236
Open

Use static copyright years #126133

hugovk opened this issue Oct 29, 2024 · 6 comments · May be fixed by #126236

Comments

@hugovk
Copy link
Member

hugovk commented Oct 29, 2024

Short version

Each January we update the PSF copyright years in the repo:

Copyright © 2001-2024 Python Software Foundation. All rights reserved.

2025 is approaching.

Can we get permission from the PSF to adopt a copyright that does not need updating every year?

I suggest something like one of the following:

Copyright © Python Software Foundation. All rights reserved.
Copyright © 2001 Python Software Foundation. All rights reserved.
Copyright © 2001-present Python Software Foundation. All rights reserved.

Longer version

Last year, we updated it in 15 places in 10 files:

Sometimes we miss a few and have to update them later:

Or we miss something, merge the fix a year late, which needs refixing:

And sometimes we backport these to (some) older branches, but other years don't:

Sometimes there's lots of duplicate PRs that end up closed and wasting everyone's time:

Not only is this tedious work, it is likely unnecessary. A lot of big projects have stopped updating copyright years: https://hynek.me/til/copyright-years/

For example:

Copyright (c) 2009 The Go Authors. All rights reserved.
Copyright (c) 2015 - present Microsoft Corporation
Copyright 2013 Netflix, Inc.
Copyright (c) Meta Platforms, Inc. and affiliates.
Copyright (c) Microsoft Corporation. All rights reserved.
Copyright (c) .NET Foundation and Contributors

These either have only have the first year, omit years altogether, or end with "present".

Can we do something similar?

Linked PRs

@Wulian233
Copy link
Contributor

Wulian233 commented Oct 30, 2024

+1
I also suggestion deleting the years of PSF 2001-20xx in other files. This should always be up to date. Currently, files with these rows are searched (200x 201x) over nearly 10~20 years. I don't think they need to repeat the statement because it's already stipulated in the LICENSE. But that's a lot of files to change (edit ~20)

example:
https://github.com/python/cpython/tree/main/Lib/email/iterators.py

2001-200x
https://github.com/search?q=repo:python/cpython 2001-200&type=code

2001-201x
https://github.com/search?q=repo:python/cpython 2001-201&type=code

@gpshead
Copy link
Member

gpshead commented Oct 31, 2024

IMNSHO lets just adopt this already. Do not update existing copyright dates in existing files.

Ex: From other your examples above - Google's policy was always "never touch the year" with the year of file creation or copyright statement addition being the standard. As noted in https://opensource.google/documentation/reference/releasing/preparing#license-headers

@hugovk
Copy link
Member Author

hugovk commented Oct 31, 2024

Do you mean leave them as-is, and stop updating them each year?

However, I expect we will still see many PRs from people who see "2001-2024" and want to help by updating to "2001-2025". It will be easy, though tedious, for us to close them, but at the expense of having wasted the time of contributors.

Or to remove the end years?

I think this is better, as I doubt we'll get PRs updating "2001" to "2001-2025". Here's a draft PR to illustrate: #126236.

@AA-Turner
Copy link
Member

From that draft PR -- seeing the version with '2024' removed as the end year leads me to slightly prefer the 'YYYY - present' option, especially in lists of several prior copyright assignments. Hugo's option 1 (no year) would also render this moot, though is slightly less consistent.

I would also suggest removing copyright comments from modules/files where the PSF is the only cited copyright holder, as this is simply duplicative information.

A

@gpshead
Copy link
Member

gpshead commented Nov 1, 2024

I would also suggest removing copyright comments from modules/files where the PSF is the only cited copyright holder, as this is simply duplicative information.

I wouldn't remove entire copyright statements from anywhere.

Hugo should reach out to the PSF (as copyright holder) for advice. Our goal is to simplify our life, have a policy to point to, and reduce toil.

We should codify said advice in our dev guide and simply reply to anyone attempting to modify copyright statements with a link to that documentation.

@hugovk
Copy link
Member Author

hugovk commented Nov 1, 2024

I've emailed PSF legal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants