-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PyDict_GetItemRef() #111789
Comments
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 6, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 7, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 7, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 7, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 10, 2023
Use new C API functions PyDict_GetItemRef() and PyMapping_GetOptionalItemString().
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 11, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 11, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 11, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Nov 14, 2023
It would perhaps be easier to review if there was one PR per file touched. That way the expert for a given file can approve (or even merge) without having to say something like "okay for foobar.c" and the PR author won't have to keep track of which files are approved. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Nov 14, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
ambv
added a commit
that referenced
this issue
Feb 23, 2024
Co-authored-by: Łukasz Langa <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this issue
Mar 4, 2024
…H-112083) Co-authored-by: Łukasz Langa <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this issue
Apr 17, 2024
…H-112083) Co-authored-by: Łukasz Langa <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Use new C API functions PyDict_GetItemRef() and PyMapping_GetOptionalItemString().
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following PR makes the code, that currently uses
PyDict_GetItemWithError()
which returns a borrowing reference and then callPy_INCREF()
on the result to make a strong reference, to usePyDict_GetItemRef()
.cc @vstinner
Linked PRs
The text was updated successfully, but these errors were encountered: