-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_sysconfig test_library fails on macOS framework installs, like the python.org installer #110824
Comments
@ned-deily could you post the output of |
|
@FFY00, I'm sorry that this is kind of late in the game, but, while reviewing @smontanaro's proposed fix in #113298, I realized I didn't know exactly what this is supposed to be testing, in particular, what is or should be the purpose on non-Windows builds of the variables mentioned in #88402. Are they intended to help with building extensions? With embedding Python? How do they fit in with the existing As it stands, it's not at all clear to me why and how I would use the
|
@FFY00, @ned-deily . How do we move forward with this? This is one of the failing tests for a framework build and I'd like to get us back at having no failing tests. The PR helps with that, but as Ned notices it is not clear what the semantics of these sysconfig variables is meant to be. The current test expectations don't match the variables usage in the Makefile for a framework build, and that usage cannot be changed. It would IMHO be better to specify a new interface for getting information needed for building/linking and implement that on top of the information we already have. That's something for a different issue though. |
Hey, sorry for the delay getting back to you, I have been taking a break for mental health reasons. I also moved house in the meantime, so things have been a bit chaotic, I am only now getting back to normal.
Yep, that is exactly the problem, there aren't really any properly defined semantics. The value of the variables here should be the value of the variables on the
Yep, that is my plan (GH-103480). |
Looking into this deeper, I don't think we should change any of the variable values. Users that want to use From
|
…work builds. (GH-113298) Co-authored-by: Ned Deily <[email protected]>
To move this forward, @smontanaro's PR has added a check to |
… framework builds. (pythonGH-113298) Co-authored-by: Ned Deily <[email protected]>
… framework builds. (pythonGH-113298) Co-authored-by: Ned Deily <[email protected]>
… framework builds. (pythonGH-113298) Co-authored-by: Ned Deily <[email protected]>
Bug report
With the python.org 3.13.0a1 installer for macOS, the new
test_library
oftest_sysconfig
fails:Linked PRs
The text was updated successfully, but these errors were encountered: