Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyErr_DisplayException(exc) as replacement for PyErr_Display(typ, exc, tb) #102755

Closed
iritkatriel opened this issue Mar 16, 2023 · 1 comment · Fixed by #102756 or #102849
Closed

Add PyErr_DisplayException(exc) as replacement for PyErr_Display(typ, exc, tb) #102755

iritkatriel opened this issue Mar 16, 2023 · 1 comment · Fixed by #102756 or #102849
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Mar 16, 2023 •
edited by bedevere-bot
Loading

Create a single-arg version of PyErr_Display.

PyErr_Display is in the stable ABI but it is not documented. PyErr_DisplayException will therefore need to be in the stable ABI as well (and documented).

Linked PRs
@iritkatriel iritkatriel added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 16, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 16, 2023
@iritkatriel
pythongh-102755: Add PyErr_DisplayException(exc)
368947d
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 16, 2023
@iritkatriel
pythongh-102755: Add PyErr_DisplayException(exc)
cd19310
@iritkatriel iritkatriel mentioned this issue Mar 16, 2023
Merged
iritkatriel added a commit that referenced this issue Mar 16, 2023
@iritkatriel
gh-102755: Add PyErr_DisplayException(exc) (#102756)
3f9285a
carljm added a commit to carljm/cpython that referenced this issue Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0 
* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 19, 2023
@iritkatriel
pythongh-102755: fix refleak
db0c66d
@bedevere-bot bedevere-bot mentioned this issue Mar 19, 2023
Merged
iritkatriel added a commit that referenced this issue Mar 19, 2023
@iritkatriel
gh-102755: fix refleak (#102826)
ccb5af7
@encukou
Copy link
Member

encukou commented Mar 20, 2023

The new function should only be available in the 3.12+ limited API, see: https://devguide.python.org/developer-workflow/c-api/#adding-a-new-definition-to-the-limited-api
Users who #define Py_LIMITED_API expect that their compiled extensions will work with older versions of Python.

Also, the PR removed all tests for PyErr_Display. Would it be possible to add at least a small smoke-test back, to ensure it continues to work?

@encukou encukou reopened this Mar 20, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 20, 2023
@iritkatriel
pythongh-102755: PyErr_DisplayException only in ABI >= 3.12. Tests co…
5658e7e 
…ver PyErr_Display as well
@iritkatriel iritkatriel mentioned this issue Mar 20, 2023
Merged
encukou pushed a commit that referenced this issue Mar 21, 2023
@iritkatriel
gh-102755: PyErr_DisplayException only in ABI >= 3.12. Tests cover Py…
5c471f3 
…Err_Display as well (GH-102849)
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
dd639e7
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102755: fix refleak (python#102826)
2cfaac1
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102755: PyErr_DisplayException only in ABI >= 3.12. Tests co…
45e8c3e 
…ver PyErr_Display as well (pythonGH-102849)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
9cd991f
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102755: fix refleak (python#102826)
32b3e9d
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102755: PyErr_DisplayException only in ABI >= 3.12. Tests co…
34faf03 
…ver PyErr_Display as well (pythonGH-102849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
2 participants
@encukou @iritkatriel