Python Triage Team Application: Brandt Bucher

[brandtbucher]

Request for Python Triage membership

	Description
GitHub username	@brandtbucher
bpo username	brandtbucher
Additional info	I'm applying to the Triage Team because I care about the long-term health and quality of the language. I also want to improve the PR process for contributors and reduce some of the wait time that I experienced during my own first few contributions. I'm definitely newer here, but I've contributed several bug fixes to CPython written in both C (37417 and 37420) and Python (17396, 20020, 25160, 35376, and 35936). I'm also a regular contributor to mypy (example contributions: #6648, #6753, and #6830) and a collaborating member of StaticFrame (example PR reviews: #68, #71, and #74). Core devs who are familiar with my work include @ilevkivskyi and gvanrossum on mypy, @stevendaprano from my work (in progress) on implementing PEP 584, and perhaps @ncoghlan on my larger CPython PR in #11787.

[aeros]

I also want to improve the PR process for contributors and reduce some of the wait time that I experienced during my own first few contributions.

I can relate strongly to your reasons for wanting to join, a large part of my motivation to join the Python triage team was to help improve the general experience of PR authors and reduce the response times. Also, your PRs look solid and we could always use more people that are familiar with both C and Python.

My only concern is that it looks like you haven't done a PR review in the Python repositories before (https://github.com/brandtbucher?org=python&year_list=1). A large part of triaging involves providing a preliminary review, applying labels, and in general helping to move PRs forward.

From your previous contributions, it looks like you've built up a decent amount of experience with the workflow and in general I think you'd be a great addition to the team. But I think you should try to build up some experience with PR reviews first and apply again afterwards.

I'm not a core developer though, I just become a member of the Python triage team a couple of days ago.

[brandtbucher]

Thanks for the feedback @aeros167. Just to clarify: I have given reviews before... just not for the Python repositories. You can see the StaticFrame PR links above for examples of this.

But yes, I never have reviewed a CPython contribution before. I was actually under the impression that you needed certain permissions (like triage) to leave/request reviews and add labels in this repo, so I never tried.

[Mariatta]

you needed certain permissions (like triage) to leave/request reviews and add labels in this repo, so I never tried.

You don't need any permission to leave review or request changes, and those reviews are definitely welcome.
There are some guidelines in devguide:
https://devguide.python.org/pullrequest/#how-to-review-a-pull-request
https://devguide.python.org/pullrequest/#leaving-a-pull-request-review-on-github

Adding labels does require at least triage role or core dev.

I haven't work with you Brandt so I won't be giving my approval at the moment.

[aeros]

But yes, I never have reviewed a CPython contribution before. I was actually under the impression that you needed certain permissions (like triage) to leave/request reviews and add labels in this repo, so I never tried.

Ah, I see. It's probably not an overly well known method of contribution. As far as I'm aware, it's only mentioned in a few of sections in the devguide, such as https://devguide.python.org/pullrequest/#how-to-review-a-pull-request.

Also to clarify, permissions are required for adding labels, but not for PR review itself. Any contributor can leave feedback and suggestions for PRs in the Python repositories.

[nanjekyejoannah]

@brandtbucher, thanks for wanting to help on the bug triage team. cc @serhiy-storchaka . I followed your work on PR 14407 . Good luck.

[aeros]

Just to clarify: I have given reviews before... just not for the Python repositories

Apologies if it sounded like I was claiming that you had never given reviews before, I was specifically referring to the repositories under the Python organization (since that's in the domain of the Python triage team). I saw the PR reviews that you linked from static-frame, and from what I could tell, they looked to be quite in-depth. It looks like you've done 6 PR reviews in total across public GitHub repositories.

[brandtbucher]

Gotcha, thanks for the clarification.

[brandtbucher]

For reference, I've started giving reviews over the last couple of days (now that I know I can)! Here are a couple of examples:

• #15326
• #15400
• #15439
• #15455
• #15459

[shihai1991]

For reference, I've started giving reviews over the last couple of days (now that I know I can)! Here are a couple of examples:

• #15326
• #15400
• #15439
• #15455
• #15459

A good start :)

[gvanrossum]

I'm happy to support (approve) Brandt's application as a triager. I've seen some of his work and it's of good quality.

[ewdurbin]

Added.

[aeros]

Congrats @brandtbucher!

[brandtbucher]

It looks like I have triage permissions on GitHub, but not on BPO. Are these separate teams, or was that step just missed for me?

[Mariatta]

That is done separately (and manually) sometimes we forgot 🙁
I've just added you as "Developer" in b.p.o. Thanks for your work!

[brandtbucher]

Thanks @Mariatta!