Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Invalid GIT_EDITOR #3

Open
wookie184 opened this issue Jun 26, 2022 · 0 comments
Open

Handle Invalid GIT_EDITOR #3

wookie184 opened this issue Jun 26, 2022 · 0 comments
Labels
question Further information is requested

Comments

@wookie184
Copy link

wookie184 commented Jun 26, 2022

Noticed because of this: microsoft/vscode#153246

This error is raised when running blurb with an invalid GIT_EDITOR environment variable ("c:\Users\wookie184\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\git-editor.sh" on windows in my case).

PS C:\Users\wookie184\Documents\GitHub\cpython> blurb
Traceback (most recent call last):
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\wookie184\AppData\Local\Programs\Python\Python39\Scripts\blurb.exe\__main__.py", line 7, in <module>
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\site-packages\blurb.py", line 1659, in main
    sys.exit(fn(*filtered_args, **kwargs))
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\site-packages\blurb.py", line 935, in add
    subprocess.run(args)
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\subprocess.py", line 505, in run
    with Popen(*popenargs, **kwargs) as process:
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "c:\users\wookie184\appdata\local\programs\python\python39\lib\subprocess.py", line 1420, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
OSError: [WinError 193] %1 is not a valid Win32 application

It isn't very clear to the user what the issue is from this error. Possible solutions:

  • Handle the error and reraise a specific error mentioning what failed to run (e.g. that GIT_EDITOR was invalid if that is the case).
  • Handle the error and try to use a fallback (e.g. notepad on windows) if GIT_EDITOR fails.

If we decide to do one of these I'd be happy to try implementing it.

Thanks!

@ezio-melotti ezio-melotti added the question Further information is requested label Jun 26, 2022
@hugovk hugovk transferred this issue from python/core-workflow Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants