Upgrade to Kazoo 2.6.0 breaks backward compatibility with KazooRetry

[ceache]

The removal of max_jitter from KazooRetry parameters in 60366d2 break upgrade from previous versions.

If this is expected, I think it should be documented.
Otherwise a simple deprecation warning and keeping the argument in an inactive form could also be done.

[StephenSorriaux]

Hi,

You're right we should have kept the argument while displaying a deprecation warning message... If you have some times to fix this, please feel free to submit a PR.

[jeffwidman]

@StephenSorriaux did you see my comment in #521 (comment)?

I guess a warning is fine, but @ceache given that you only should have hit this if upgrading from 1.2, I'm guessing there's a whole slew of other backwards incompatible changes you should have hit...

(Sorry for swinging by late, I have been buried and not on top of my notifications)

[StephenSorriaux]

@jeffwidman No, I did not... I might be missing something but isn't the deprecation you are refering to in #521 about the KazooClient object?

[ceache]

We did not either.

We hit this because we were creating KazooRetry objects directly, not through the KazooClient constructor, which is not displaying any deprecation warnings.

Shouldn't the this machinery be moved to kazoo.retry instead and consolidated?

[StephenSorriaux]

I'm closing this issue since #545 fixes it.