Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe: add {before,after}_io_wait callbacks to instrument interface? #34

Closed
njsmith opened this issue Jan 24, 2017 · 1 comment
Closed

Comments

@njsmith
Copy link
Member

njsmith commented Jan 24, 2017

It's trivial to do and gives useful information; I'm just a bit hesitant because depending on the outcome to #32, we might or might not have a discrete handle_io step in the scheduler loop.

@njsmith njsmith changed the title Maybe: add {before,after}_io_wait callbacks to instrument? Maybe: add {before,after}_io_wait callbacks to instrument interface? Jan 24, 2017
@njsmith
Copy link
Member Author

njsmith commented Feb 22, 2017

On further thought, it still makes sense even if we change the scheduler loop -- we just might be doing more calls to check for IO, with 0 timeout. So I added this.

@njsmith njsmith closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant