-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic Asyncio support #210
Conversation
Looks good so far! Will re-review when you think it's done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rebase on master, add ASYNC102
support, and then we're probably done?
…ssing on asyncio, though not necessarily for good reasons
…rk with which library, and minor updates. 102/103/104 now sees asyncio.exceptions.CancelledError as a critical exception. Fix import/arg detection of asyncio. add asyncio102_asyncio. add async103_all_imported. Finally make test_anyio_from_config autodetect the correct line number. Fix BASE_LIBRARY marker being interpreted as a bool. Make #NOTRIO/#NOASYNCIO/#NOANYIO run the visitor but ignore the result, instead of skipping, to check it doesn't crash. Generalize error-message-library-check.
Uh, I ended up doing A Lot:tm:. But the diff didn't actually end up being all that big. The rebase might break viewing only new changes though, so you might want to review commit-by-commit. Only ones listed in #208 not supported now is:
So I'm now comfortable saying this has decent TODO: Oh I did rename the repository, so should update links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; agree that we could release this and should release whatever we have on the weekend (when I set up release automation again).
I'll let you merge after any docs/links updates you want to make.
Co-authored-by: Zac Hatfield-Dodds <[email protected]>
ah oops, I realized I forgot to ask your opinion on |
I'd probably go with the slash, but don't really care so long as we're consistent. |
first steps on #208
106, 200, 21x and 9xx are supported, though no autofix.
This is rebased on top of #209, so if reviewing you should only look at the latest commit(s).
todo:
--library
flag instead.