Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PyQt5.sip.array generic #83

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Make PyQt5.sip.array generic #83

merged 1 commit into from
Sep 27, 2020

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Sep 25, 2020 •
edited
Loading

Draft for:

  • Recreating the error

@BryceBeagle
Copy link
Collaborator

What problem does this solve?

@altendky
Copy link
Collaborator Author

:[ I've been forgetting to add the resolved messages here tonight... And now that I look back I'm not seeing it. Then again, early tonight I had a venv that was listing out 400 errors instead of 80 and I'm not sure why. So, I'll draft this until I figure it out.

Anyways, there was at some point an error about sip.array getting a type parameter but not being generic and this fixed it.

@altendky altendky marked this pull request as draft September 25, 2020 03:56
@altendky
Copy link
Collaborator Author

https://travis-ci.org/github/stlehmann/PyQt5-stubs/builds/730156337

PyQt5-stubs/QtQuick.pyi:826: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:879: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:880: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:881: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:882: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:883: error: "array" expects no type arguments, but 1 given
PyQt5-stubs/QtQuick.pyi:897: error: "array" expects no type arguments, but 1 given

@altendky altendky marked this pull request as ready for review September 25, 2020 05:12
@altendky altendky merged commit e7452de into python-qt-tools:master Sep 27, 2020
@altendky altendky deleted the array_generic branch September 27, 2020 00:16
bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
@altendky
Merge pull request python-qt-tools#83 from altendky/array_generic
4c1a70e 
Make PyQt5.sip.array generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceBeagle BryceBeagle BryceBeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @BryceBeagle