Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove class layer #79

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Remove class layer #79

merged 2 commits into from
Sep 24, 2020

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Sep 23, 2020 •
edited
Loading

Ref #60.

Draft for:

  • I think I missed all the Qt3D* stuff

@altendky altendky marked this pull request as draft September 23, 2020 15:58
@altendky altendky changed the title Remove class layer from QtCharts and QtDataVisualization Remove class layer Sep 23, 2020
@altendky altendky marked this pull request as ready for review September 23, 2020 16:10
@altendky
Copy link
Collaborator Author

This is basically impossible to review here. What I at least meant to do was to delete the class definition and dedent everything in side. PyCharm's diff is at least able to visualize this diff well. I'm not sure what else does... but not GitHub.

BryceBeagle
BryceBeagle approved these changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@BryceBeagle BryceBeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this PR as a reason to give the GitHub integration in PyCharm a shot. Pretty nifty! I might start using this more in the future. The diffing worked great on some of the files once I told it to ignore whitespace changes. It did not work great on the files once a line started wrapping at a different point....

I skimmed all the files that didn't diff properly and didn't notice anything egregious. I'll assume this works properly.

@altendky altendky merged commit bac9d71 into python-qt-tools:master Sep 24, 2020
@altendky altendky deleted the remove_class_layer branch September 24, 2020 13:52
bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
@altendky
Merge pull request python-qt-tools#79 from altendky/remove_class_layer
461e5dc 
Remove class layer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceBeagle BryceBeagle BryceBeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @BryceBeagle