Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests #195

Merged
merged 19 commits into from
Feb 13, 2023
Merged

Add more tests #195

merged 19 commits into from
Feb 13, 2023

Conversation

bluebird75
Copy link
Collaborator

No description provided.

bluebird75 added 11 commits April 26, 2022 08:36
@bluebird75
Add one test to check for possible None value of QApplication.instance()
e4d9be7 
See python-qt-tools#126
@bluebird75
Check disconnect optional argument, as reported in python-qt-tools#103
712d4ed
@bluebird75
Ensure connect() returns a Connection() object. See PR python-qt-tool…
7eb3d46 
…s#54
@bluebird75
Add tests and fixes for all view items comparison (with inspiratino f…
0f405e2 
…rom python-qt-tools#33
@bluebird75
Add tests for QProgressDialog.setCancelButton() (from python-qt-tools#32
9701690 
)
@bluebird75
Add tests and comparison for QModelIndex (inspiration from python-qt-…
64f8687 
…tools#28)
@bluebird75
attempt to capture sip.array typing from python-qt-tools#100
8db8171
@bluebird75
attempt to capture sip.array typing from python-qt-tools#100
e42a9fe
@bluebird75
More tests on voidptr (from python-qt-tools#104)
e296cfc
@bluebird75
Add a few more example of pyqtSlot() usage, inspiration from python-q…
b034933 
…t-tools#102
@bluebird75
Add one test for qtest (inspiration from an old commit)
a051574
@bluebird75
Copy link
Collaborator Author

I reviewed all PR, issues and commit since the beginning of the projects. I tried to add tests for most things which were actually changed during this lifetime, with the exception of signals and enum which are handled by automation scripts.

The idea for me is to capture all user contributions into the test suite, which can serve as a basis for other pyqt-stubs projects.

@bluebird75
Copy link
Collaborator Author

Ready to be merged

altendky
altendky reviewed May 1, 2022
View reviewed changes
PyQt5-stubs/QtWidgets.pyi Outdated Show resolved Hide resolved
PyQt5-stubs/QtWidgets.pyi Outdated Show resolved Hide resolved
tests/pyqtsignal.py Show resolved Hide resolved
tests/pyqtslot.py Show resolved Hide resolved
tests/pyqtslot.py Show resolved Hide resolved
tests/qtest.py Outdated Show resolved Hide resolved
tests/pyqtsignal.py Outdated
connection = instance.signal.connect(instance.my_slot)
instance.signal.disconnect()
connection = instance.signal.connect(instance.my_slot)
instance.signal.disconnect(connection)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing EOL.

@bluebird75
Copy link
Collaborator Author

@altendky do you want to review the changes after your review ? I believe this is ready to be merged.

altendky
altendky approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued work on this.

@bluebird75 bluebird75 merged commit bd1c7e0 into python-qt-tools:master Feb 13, 2023
@bluebird75 bluebird75 deleted the add-more-tests branch February 13, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluebird75 @altendky