Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of all signals. Script to annotate signals automatically. #162

Merged
merged 7 commits into from
Dec 27, 2021

Conversation

TilmanK
Copy link
Contributor

@TilmanK TilmanK commented Aug 24, 2021

No description provided.

This was referenced Aug 27, 2021
@bluebird75
Copy link
Collaborator

I love the approach and I have been using CST as well for annotating QFlags better.

I am worried though because your changes have marked incorrectly a method as a signal :

QtWidgets.QGraphicsScene :

  • def focusOnTouch(self) -> bool: ...
  • focusOnTouch: typing.ClassVar[QtCore.pyqtSignal]

focusOnTouch is actually a property (see https://doc.qt.io/qt-5/qgraphicsscene.html) . If this one was marked incorrectly, there could be others. Could you investigate this particular case and see if it is a general problem or maybe just a PyQt5 stubs bug. While working with QFlags and CST, I have found a few buggy generated classes.

Quick reviewing the changes did not reveal anything else.

@bluebird75
Copy link
Collaborator

I checked again. Actually, focusOnTouch is already incorrectly declared as a signal, it has nothing to do with your script. So, I'll complete the review and organize the merging.

@bluebird75 bluebird75 merged commit ad6a365 into python-qt-tools:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants