Add all qflags bases classes

[bluebird75]

I started from my work on windowFlags and look for ways to make it generic. I failed at defining a generic approach with mypy, protocols and generics inheriting from int, it is really above my understanding of mypy.

But, it's easy enough to generate a file for each QFlag based class which can be used to assert both the actual implementation types and values, and which ensures that the class is being correctly checked. This is what I am doing here for two classes : WindowFlags and Alignment.

With a few more hours, I should be able to cover all qflags based class. This would remove a big hole in PyQt stubs.

[altendky]

I'll suggest this quickly now, in case you are around and we can get the CI fixed. I'll go back to reviewing the test code now.

[bluebird75]

The file where I would be interested for your review is qflags_aligmentflags.py . It uses a mostly generic approach on QFlag and QFlags based classes to check all operations on both mypy and python side.

Only two lines are specific to AlignementFlag in this file. I have work in progress to generate one similar file per QFlag based class (for the testing side) and applying automatically a fix to the pyi files to add the missing methods.

requested change was made

[bluebird75]

This is all green finally. Code is ready to be merged.

[bluebird75]

Hi Kyle. Can you start reviewing that one ? It is the result of a long work so I would be thrilled to have it integrated.

[altendky]

Several remaining nitpicks about the use of pathlib (which I do very much like). A general note I didn't point out everywhere is that I use path not filename for pathlib.Paths. Feel free to merge after going through the suggestions.

For another PR, it would be good for the generation to be run in every CI run and for there to be a CI failure if the generation results in any changes, additions, or removals.

[bluebird75]

Thanks for the feedback. This read_text() was unknown to me and I appreciated the other ideas. The code was not written with top standards but to achieve a useful purpose. It probably could be improved.

It is not really feasible to run the generation on CI. First, it is very time consuming because libcst needs to parse the huge PyQt5 modules for each QFlag generation. Second, the source of the QFlag information is a manual grep over Qt sources, which requires some user modifications before being a proper source for complete generation.

But it's a good idea to run it on new Qt or PyQt releases.