Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel uninstalls #9264

Closed
wants to merge 1 commit into from
Closed

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Apr 3, 2024

Pull Request Check List

Resolves: #9263

I tested this by trying to reproduce via @abn 's script:

#!/usr/bin/env bash -e

TMP_DIR=$(mktemp -d)
TOML=${TMP_DIR}/pyproject.toml

function reset-pyproject() {
  cat >"${TOML}" <<EOF
[tool.poetry]
name = "foobar"
version = "0.1.0"
description = ""
authors = ["Bender Rodriguez <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.8"

[tool.poetry.dev-dependencies]
ipython = "*"
EOF
}

mkdir -p "${TMP_DIR}/foobar"
touch "${TMP_DIR}/foobar/__init__.py"

POETRY=$(PWD)/.venv/bin/poetry

pushd "${TMP_DIR}" || exit

for i in $(seq 1 10); do
  reset-pyproject
  "${POETRY}" lock
  "${POETRY}" install
  sed -i '' '/ipython/d' "${TOML}" # On macOS, use 'sed -i '' '...' to edit in-place
  "${POETRY}" lock
  "${POETRY}" install --sync
done

popd || exit

I was not able to reproduce the original issue and uninstalls are considerably faster.

@adriangb adriangb closed this Apr 3, 2024
Copy link

github-actions bot commented May 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant