Fix building distribution of PEP 561 stub-only packages #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henribru
reviewed
Feb 22, 2020
|
@finswimmer I have accidentally removed the review request you have added - can you add it again? |
laurentS
added a commit
to laurentS/neomodel-stubs
that referenced
this pull request
Apr 3, 2020
There is a bug in poetry, which should be fixed with python-poetry/poetry#2000 but until then, having this extra file seems to allow installation.
abn
requested changes
Apr 22, 2020
…wheel Signed-off-by: Oleg Höfling <[email protected]>
Signed-off-by: Oleg Höfling <[email protected]>
Signed-off-by: Oleg Höfling <[email protected]>
Signed-off-by: Oleg Höfling <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
|
@abn sure thing, done! |
abn
requested changes
Apr 22, 2020
Signed-off-by: oleg.hoefling <[email protected]>
|
@abn no worries, better apply changes now than deal with bad design later. I guess I was too distracted by |
abn
approved these changes
Apr 22, 2020
|
@hoefling thank you for the fix; feel free to provide a port of the fix to python-poetry/core repo too if you can. Otherwise, I can do a port sometime later this week. |
hoefling
added a commit
to hoefling/core
that referenced
this pull request
Apr 22, 2020
Signed-off-by: oleg.hoefling <[email protected]>
2 tasks
|
@abn gladly, was actually easier than I thought. python-poetry/poetry-core#28 |
abn
pushed a commit
to python-poetry/poetry-core
that referenced
this pull request
Apr 22, 2020
Signed-off-by: oleg.hoefling <[email protected]>
abn
added a commit
to python-poetry/poetry-core
that referenced
this pull request
Apr 22, 2020
This reverts commit c7b924b.
Merged
2 tasks
3 tasks
Merged
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Updated documentation for changed codeno documentation updates needed, this patch only fixes what has worked before.This is a fix for a regression in #475, first introduced in c401850. Added explicit check for PEP 561 stub-only packages, put duplicate code in a separate method. To avoid the regression reintroduced, added tests for:
Thank you in advance for a review!