Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pre-commit-hooks page should remove the use of poetry-lock as it is deprecated. #8674

Closed
1 task done
iamibi opened this issue Nov 14, 2023 · 2 comments · Fixed by #8675
Closed
1 task done

The pre-commit-hooks page should remove the use of poetry-lock as it is deprecated. #8674

iamibi opened this issue Nov 14, 2023 · 2 comments · Fixed by #8675
Labels
area/docs Documentation issues/improvements

Comments

@iamibi
Copy link
Contributor

iamibi commented Nov 14, 2023

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

The pre-commit-hooks page currently shares the information on using poetry-lock plugin which has be deprecated. The poetry-check plugin instead can be used with the argument args: ["--lock"] as suggested by the following deprecation warning

poetry lock --check is deprecated, use `poetry check --lock` instead.
@iamibi iamibi added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Nov 14, 2023
@dimbleby
Copy link
Contributor

poetry lock is not deprecated.

(Only poetry lock --check is deprecated, but the hook is more general than that)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@abn abn removed the status/triage This issue needs to be triaged label Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants