Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry >1.6.0 depends on urllib > 2 by default #8381

Closed
4 tasks done
ebarti opened this issue Aug 29, 2023 · 6 comments
Closed
4 tasks done

Poetry >1.6.0 depends on urllib > 2 by default #8381

ebarti opened this issue Aug 29, 2023 · 6 comments
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@ebarti
Copy link

ebarti commented Aug 29, 2023

  • Poetry version: 1.6.0
  • Python version: 3.8
  • OS version and name: public.ecr.aws/lambda/python:3.8
  • pyproject.toml: N/A
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

Starting at Poetry 1.6, it ships with a urllib>2 dependency which is incompatible with public.ecr.aws/lambda/python:3.8. Just adding this issue so people do not waste their time debugging a non-fixable issue.

@ebarti ebarti added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Aug 29, 2023
@ebarti
Copy link
Author

ebarti commented Aug 29, 2023

Closing as it is not an issue, just for viz.

@ebarti ebarti closed this as completed Aug 29, 2023
@dimbleby
Copy link
Contributor

dimbleby commented Aug 29, 2023

fwiw poetry does not "ship with a urllib>2 dependency". Indeed poetry does not mention urllib3 at all.

Rather: poetry has dependencies, and those dependencies ship with a urllib3 < 3 dependency (nb not urllib3 > 2).

ie urllib3 > 2 is allowed, but not required.

if you want to put urllib3 < 2 into your poetry installation then so far as I know neither poetry nor any of its dependencies will stop you.

(but you will miss out on bug fixes eg this one)

@ebarti ebarti changed the title Poetry >1.6.0 compiled with urllib >2 without clear indication Poetry >1.6.0 depends on urllib > 2 by default Aug 29, 2023
@ebarti
Copy link
Author

ebarti commented Aug 29, 2023

Hey @dimbleby thank you for the note (and for your patience 😛 ).

Out of sheer curiosity, how could I install poetry 1.6.x so that it depends on urllib3 <2?

@dimbleby
Copy link
Contributor

just pip install urllib3==1.whatever in the virtual environment in which you installed poetry

eg if you used pipx to install poetry then pipx runpip ...

@ebarti
Copy link
Author

ebarti commented Aug 30, 2023

My bad, I never noticed that it indeed creates its own venv. Solved!

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants