Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with --without flag #7991

Closed
gaboc623 opened this issue May 23, 2023 · 4 comments
Closed

Issue with --without flag #7991

gaboc623 opened this issue May 23, 2023 · 4 comments
Labels
area/docs Documentation issues/improvements status/triage This issue needs to be triaged

Comments

@gaboc623
Copy link

gaboc623 commented May 23, 2023

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate.

Issue

  • the functionality for the --without flag for poetry install seems to have changed in 1.5.0 to only allow groups as the arguments passed, whereas before we could pass individual package names separated by commas to exclude from the install
  • if the functionality changed, could it be added to the release notes?
  • or if this is a bug should I open a different ticket for it?
    Screenshot 2023-05-23 at 2 28 03 PM
    In the image you see here, a3s and cerberuscli are internal packages that we exclude from our Github Actions runners as they are not needed, but are no longer accepted as arguments to the --without flag
@gaboc623 gaboc623 added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels May 23, 2023
@dimbleby
Copy link
Contributor

dimbleby commented May 23, 2023

if the behaviour has changed here, then it is a bug fix, --without was always intended for groups:

$ poetry --version
Poetry (version 1.4.2)

$ poetry install --help | grep without
      --without=WITHOUT      The dependency groups to ignore. (multiple values allowed)

please close

@gaboc623
Copy link
Author

sounds good thanks

@dimbleby
Copy link
Contributor

Yep, #7529 - which is in fact already mentioned in the release notes.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants