Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin versions should be configurable as project dependencies #7657

Closed
2 tasks done
rowanseymour opened this issue Mar 16, 2023 · 6 comments
Closed
2 tasks done

Plugin versions should be configurable as project dependencies #7657

rowanseymour opened this issue Mar 16, 2023 · 6 comments
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@rowanseymour
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

Plugins are super useful and we're now using https://github.com/monim67/poetry-bumpversion in our projects to keep __version__ in the code in sync with the version in pyproject.toml. This plugin is configured by simply adding

[tool.poetry_bumpversion.file."your_package/__init__.py"]

However, if someone builds the project and doesn't have bumpversion installed as a plugin, that is silently ignored and __version__ is not updated. We need a way to declare that building this project requires bumpversion>=x.y.z to keep builds reproducible and consistent.

Or maybe at least poetry could error if it sees a config section that doesn't correspond to core or a known plugin?

@matinone
Copy link

matinone commented Nov 1, 2023

This would be a great feature to have, and there seems to be quite some interest based on this issue and this StackOverflow question.

@Secrus
Copy link
Member

Secrus commented Oct 6, 2024

This feature was recently merged into main, will be available in the next release.

@Secrus Secrus closed this as completed Oct 6, 2024
@allanlewis
Copy link
Contributor

This feature was recently merged into main, will be available in the next release.

This is great news - thanks to everyone who worked on this feature!

@dolfinus
Copy link

dolfinus commented Oct 6, 2024

@Secrus could you please link a PR where this feature was implementing?

@jakobkogler
Copy link

This was implemented in #9547.

Copy link

github-actions bot commented Nov 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

6 participants