Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #3368 Poetry install fails for nested local dependencies and develop = false #7539

Closed
4 tasks done
fiahil opened this issue Feb 21, 2023 · 6 comments
Closed
4 tasks done
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@fiahil
Copy link

fiahil commented Feb 21, 2023

  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

Hi,

I'm following up on #3368 and #4245.

While it appears the issue was resolved for local path dependencies, it still happens when the top-most dependency is a VCS dependency.

I attached a repo for a painless reproduction.

Cheers !

@fiahil fiahil added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Feb 21, 2023
@fiahil
Copy link
Author

fiahil commented Mar 6, 2023

Hi,

I just identified a regression in v1.4.0. Same setup over git version was working in v1.3.2 after patching the poetry.lock. Now, v1.4.0, can't install subdirectory dependencies properly (poetry.lock looks good)...

Do you want me to create another issue for that (similar) problem ?

@fiahil fiahil changed the title Follow-up to #3368 Poetry install fails for nested local dependencies and develop = false Follow-up to #3368 Poetry install fails for nested local dependencies and develop = false // Poetry v1.4.0 subdirectory install regression Mar 6, 2023
@dimbleby
Copy link
Contributor

dimbleby commented Mar 6, 2023

not before searching harder for duplicates #7575

@alvaromerinog

This comment was marked as off-topic.

@dimbleby
Copy link
Contributor

dimbleby commented Mar 9, 2023

please refrain from discussing git subdirectory issues here, that's not what this issue describes - and is covered by #7575

@fiahil fiahil changed the title Follow-up to #3368 Poetry install fails for nested local dependencies and develop = false // Poetry v1.4.0 subdirectory install regression Follow-up to #3368 Poetry install fails for nested local dependencies and develop = false Mar 17, 2023
@fiahil
Copy link
Author

fiahil commented Mar 17, 2023

Tried again, and it seems that #7575 / #7580 has fixed this issue !

@fiahil fiahil closed this as completed Mar 17, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants