Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a build script an arbitrary platform tag is chosen. #4168

Closed
2 of 3 tasks
gitonthescene opened this issue Jun 10, 2021 · 3 comments
Closed
2 of 3 tasks

When using a build script an arbitrary platform tag is chosen. #4168

gitonthescene opened this issue Jun 10, 2021 · 3 comments
Labels
kind/bug Something isn't working as expected

Comments

@gitonthescene
Copy link

gitonthescene commented Jun 10, 2021

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

This is more or less what I described here.

I upgraded from poetry v1.0.6 and now the platform of by builds using a build script have changed from cp37-cp37m-macosx_11_2_x86_64 to cp38-cp38-macosx_11_0_x86_64 and thus I am unable to build and hence run my package against python3.7. The upgrade of poetry was the only thing that changed.

I believe I've tracked this down to the fact that the platform is in fact artbitrary. It's simply the first in the list returned from sys_tags(). It should probably be chosen to be compatible with the contents of the wheel. i.e. it should use whatever algorithm the build did to determine the platform.

In my case here's what the contents look like. Notice that the wheel is one platform but the .so in the wheel is another.

$ poetry build --format=wheel
Building csv-reconcile (0.2.5)
  - Building wheel
A setup.py file already exists. Using it.
running build
running build_py
running build_ext
  - Built csv_reconcile-0.2.5-cp38-cp38-macosx_11_0_x86_64.whl
$ unzip -l dist/csv_reconcile-0.2.5-cp38-cp38-macosx_11_0_x86_64.whl 
Archive:  dist/csv_reconcile-0.2.5-cp38-cp38-macosx_11_0_x86_64.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     5926  01-01-1980 00:00   csv_reconcile/__init__.py
       27  01-01-1980 00:00   csv_reconcile/__main__.py
      568  01-01-1980 00:00   csv_reconcile/db.py
      238  01-01-1980 00:00   csv_reconcile/default_settings.py
      934  01-01-1980 00:00   csv_reconcile/extend.py
     2979  01-01-1980 00:00   csv_reconcile/initdb.py
      167  01-01-1980 00:00   csv_reconcile/schema.sql
     2531  01-01-1980 00:00   csv_reconcile/score.py
     1835  01-01-1980 00:00   csv_reconcile/scorer.py
     1327  01-01-1980 00:00   csv_reconcile_dice/__init__.py
   130540  01-01-1980 00:00   csv_reconcile_dice/cutils.c
      689  01-01-1980 00:00   csv_reconcile_dice/cutils.pyx
      604  01-01-1980 00:00   csv_reconcile_dice/utils.py
    25691  01-01-1980 00:00   csv_reconcile/cutils.html
    58600  01-01-1980 00:00   csv_reconcile/cutils.cpython-37m-darwin.so
      724  01-01-1980 00:00   csv_reconcile/cutils.pyx~
       27  01-01-1980 00:00   csv_reconcile/extend.py~
       90  01-01-1980 00:00   csv_reconcile/scorer.py~
      641  01-01-1980 00:00   csv_reconcile/utils.pyx~
   117159  01-01-1980 00:00   csv_reconcile/cutils.c
      724  01-01-1980 00:00   csv_reconcile/utils.py~
    58880  01-01-1980 00:00   csv_reconcile_dice/cutils.cpython-37m-darwin.so
     1121  01-01-1980 00:00   csv_reconcile_dice/__init__.py~
      101  01-01-2016 00:00   csv_reconcile-0.2.5.dist-info/entry_points.txt
     1070  01-01-1980 00:00   csv_reconcile-0.2.5.dist-info/LICENSE
      100  01-01-2016 00:00   csv_reconcile-0.2.5.dist-info/WHEEL
    11660  01-01-2016 00:00   csv_reconcile-0.2.5.dist-info/METADATA
     2342  01-01-2016 00:00   csv_reconcile-0.2.5.dist-info/RECORD
---------                     -------
   427295                     28 files
$

Separately, I'm only just noticing that the wheel contains the emacs tilde files. I wonder if there's an easy method for excluding them.

@gitonthescene gitonthescene added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 10, 2021
@gitonthescene
Copy link
Author

gitonthescene commented Jun 10, 2021

It would seem you’d want to emulate the logic here where the heart of the logic is here

@gitonthescene
Copy link
Author

Duplicate of #3509

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants