Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hooks to always be sync after a git checkout #2863

Closed
2 tasks done
tetienne opened this issue Aug 28, 2020 · 6 comments · Fixed by #8327
Closed
2 tasks done

pre-commit hooks to always be sync after a git checkout #2863

tetienne opened this issue Aug 28, 2020 · 6 comments · Fixed by #8327
Assignees
Labels
kind/feature Feature requests/implementations status/waiting-on-response Waiting on response from author

Comments

@tetienne
Copy link

tetienne commented Aug 28, 2020

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Issue

Hi,

I have several projects where we update regularly the dependencies thank to dependabot. My collaborators and I have to think to redo poetry update each time we git pull or git checkout.

So I wrote a small pre-commit hook to ease this process: https://github.com/tetienne/pre-commit-hooks

It will be interesting to host such hooks directly under https://github.com/python-poetry/poetry or perhaps under a dedicated project https://github.com/python-poetry/pre-commit-hooks.

What do you think?

@finswimmer finswimmer added kind/feature Feature requests/implementations status/waiting-on-response Waiting on response from author labels Dec 23, 2021
@finswimmer
Copy link
Member

Hey @tetienne,

sounds like in interesting idea. In the meantime we provide some pre-commit hooks and I think your suggestion would fit quite nice. Do you mind providing a PR for it?

fin swimmer

@tetienne
Copy link
Author

Thx for this ping. I didn't notice there was now some hooks hosted here. That's great.
Sure I will try to open a PR with my suggestion.

@finswimmer finswimmer removed the status/waiting-on-response Waiting on response from author label Jan 21, 2022
@Secrus
Copy link
Member

Secrus commented Apr 18, 2023

@tetienne are you still interested in doing this?

@Secrus Secrus added the status/waiting-on-response Waiting on response from author label Apr 18, 2023
@Secrus Secrus self-assigned this Aug 16, 2023
@alsmnn
Copy link
Contributor

alsmnn commented Aug 17, 2023

@Secrus are you already on this? I just wanted to create a PR.

@finswimmer
Copy link
Member

@alsmnn We still think this can add value to some people. So feel free to start working on this and submit a PR 🙏

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/waiting-on-response Waiting on response from author
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants