Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save canonical PyPi names in pyproject.toml #2098

Closed
3 tasks done
adisbladis opened this issue Feb 28, 2020 · 1 comment · Fixed by #2305
Closed
3 tasks done

Save canonical PyPi names in pyproject.toml #2098

adisbladis opened this issue Feb 28, 2020 · 1 comment · Fixed by #2305
Labels
kind/bug Something isn't working as expected

Comments

@adisbladis
Copy link
Contributor

adisbladis commented Feb 28, 2020

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name:
  • Poetry version:
  • Link of a Gist with the contents of your pyproject.toml file:

Issue

When running poetry add (& other commands) the package names is saved verbatim from the command line instead of the canonical normalised PyPi name.

Current:
$ poetry add dJaNgO

pyproject.toml contents:

name = "testproject"
version = "0.1.0"
description = ""
authors = ["Your Name <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.7"
dJaNgO = "^3.0.3"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

Expected:
$ poetry add dJaNgO

pyproject.toml contents:

name = "testproject"
version = "0.1.0"
description = ""
authors = ["Your Name <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.7"
Django = "^3.0.3"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"
@adisbladis adisbladis added the kind/bug Something isn't working as expected label Feb 28, 2020
finswimmer pushed a commit that referenced this issue Aug 16, 2020
read package name from pypi info .info.name
close #2098
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant