Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry Build not honouring .gitignore #1660

Closed
3 tasks done
SimonBiggs opened this issue Dec 2, 2019 · 4 comments
Closed
3 tasks done

Poetry Build not honouring .gitignore #1660

SimonBiggs opened this issue Dec 2, 2019 · 4 comments
Labels
kind/bug Something isn't working as expected

Comments

@SimonBiggs
Copy link

SimonBiggs commented Dec 2, 2019

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

It appears as though the following line within a .gitignore file is not being honoured by poetry build:

https://github.com/pymedphys/pymedphys/blob/9b24bad2520684793b35193191cdb470809b8b05/pymedphys/_app/.gitignore#L10

See the corresponding PyPI release which contains the build directory which should not have been included:

https://pypi.org/project/pymedphys/0.13.0.dev0/#files

image

Keen for any pointers on how to get this directory not included within the release artefact.

Cheers,
Simon

@SimonBiggs SimonBiggs added the kind/bug Something isn't working as expected label Dec 2, 2019
@finswimmer
Copy link
Member

Hello @SimonBiggs,

could you please check if all files of the folders are listed in the output of git ls-files --others -i --exclude-standard. This is what poetry does, to get the files excluded by .gitgnore.

If not all files are listed here, you most likely added them to get tracked by git, before creating the entry in .gitignore. If this is the case, remove these files from tracking by git rm --cached <file-name> or git rm -r --cached <folder-name>

fin swimmer

@SimonBiggs
Copy link
Author

Thanks for the tip. I just rebuilt it at work on a Windows 10 PC and I didn't encounter the same issue (without any changes undergone to the repo).

I'll investigate regarding your tip tonight on my Linux PC.

Cheers,
Simon

@finswimmer
Copy link
Member

Hey @SimonBiggs ,

any news on this?

fin swimmer

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants