extras installed by default

[esciara]

• I am on the latest Poetry version.

• I have searched the issues of this repo and believe that this is not a duplicate.

• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option). N/A

• OS version and name: macos mojave 10.14.6

• Poetry version: 0.12.17

• Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/esciara/aee9b5ed11f9af7b907df9ae6d656caa

Issue

Expected behavior

Following the extras documentation statement:

Poetry supports extras to allow expression of:

• optional dependencies, which enhance a package, but are not required; and
• clusters of optional dependencies.

Extras should not be installed by default when performing a poetry install, but should be installable only explicitly through a poetry install -E <extra>.

Actual behavior

Extras added with poetry add <package> -E <extra> are installed by default when doing a poetry install.

Further explanations

Performing a poetry add behave -E bdd generates the following in the pyproject.toml file adds the following:

# ~~ snip ~~

[tool.poetry.dependencies]
behave = {version = "^1.2", extras = ["bdd"]}

# ~~ snip ~~

The generated line is without an optional = true, which leads to the package being installed by default with a poetry install.

Workaround

Adding package with poetry add <package> -E <extra> --optional.

Resolution

Change the default behavior of poetry add <package> -E <extra> to be equivalent to poetry add <package> -E <extra> --optional.

[esciara]

Following my comment at #1145 (comment) , isn't poetry add <package> -E <extra> actually not working properly at all?

Should it not have generated this in pyproject.toml:

# ~~ snip ~~

[tool.poetry.dependencies]
behave = {version = "^1.2", optional = true} 

[tool.poetry.extras]
bdd = ["behave"]

# ~~ snip ~~

[esciara]

Closing as -E defines the extras to activate for the dependency, not to declare an extra for the package. There is no option on the cli to do that. Ongoing discussion to eventually create one.

See #1145 (comment).

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.