Adding forked repositories

[TheSven73]

In #9658 (comment), @seeker25 asked if our executor class can correctly handle forked repos with the same name. It currently cannot.

However, I can't seem to find a way to actually do this. The other Poetry layers don't seem let me (which is a good thing!)

click = {git = "https://github.com/TheSven73/click.git"}
click = "^8.1.7"

$ poetry lock
Cannot overwrite a value (at line 16, column 17)

clicker = {git = "https://github.com/TheSven73/click.git"}
click = "^8.1.7"

$ poetry lock
Updating dependencies
Resolving dependencies... (5.3s)

The dependency name for clicker does not match the actual package's name: click

@gustavgransbo @radoering can you think of a way to trigger a problem with a forked repo?

[radoering]

It should only be possible with different packages in subdirectories as in the example in #9658 (comment):

pkg_1 = {git = "[email protected]:foo/my_packages.git", subdirectory = "pkg_1"}
pkg_2 = {git = "[email protected]:bar/my_packages.git", subdirectory = "pkg_2"}

[TheSven73]

Thanks ! Using your example, poetry lock crashes. That doesn't sound like an executor problem, maybe there are issues elsewhere preventing this usecase?

[tool.poetry.dependencies]
python = "^3.10"
click1 = {git = "https://github.com/TheSven73/click.git", subdirectory = "click1"}
click2 = {git = "https://github.com/pallets/click.git", subdirectory = "click2"}

$ poetry lock
Updating dependencies
Resolving dependencies... (3.0s)

Unable to determine package info for path: /home/vscode/.cache/pypoetry/virtualenvs/hypermodern-python-DX2d3nwa-py3.12/src/click/click1

Command ['/tmp/tmp30um4tpp/.venv/bin/python', '-I', '-W', 'ignore', '-c', "import build\nimport build.env\nimport pyproject_hooks\n\nsource = '/home/vscode/.cache/pypoetry/virtualenvs/hypermodern-python-DX2d3nwa-py3.12/src/click/click1'\ndest = '/tmp/tmp30um4tpp/dist'\n\nwith build.env.DefaultIsolatedEnv() as env:\n    builder = build.ProjectBuilder.from_isolated_env(\n        env, source, runner=pyproject_hooks.quiet_subprocess_runner\n    )\n    env.install(builder.build_system_requires)\n    env.install(builder.get_requires_for_build('wheel'))\n    builder.metadata_path(dest)\n"] errored with the following return code 1

Error output:
Traceback (most recent call last):
  File "<string>", line 9, in <module>
  File "/tmp/tmp30um4tpp/.venv/lib/python3.12/site-packages/build/__init__.py", line 199, in from_isolated_env
    return cls(
           ^^^^
  File "/tmp/tmp30um4tpp/.venv/lib/python3.12/site-packages/build/__init__.py", line 174, in __init__
    _validate_source_directory(source_dir)
  File "/tmp/tmp30um4tpp/.venv/lib/python3.12/site-packages/build/__init__.py", line 72, in _validate_source_directory
    raise BuildException(msg)
build._exceptions.BuildException: Source /home/vscode/.cache/pypoetry/virtualenvs/hypermodern-python-DX2d3nwa-py3.12/src/click/click1 is not a directory

No fallback setup.py file was found to generate egg_info.

[radoering]

The subdirectory must be the base directory of the python project (the directory where the pyproject.toml is located). Thus, you need some sort of monorepo with several python projects inside.

[gustavgransbo]

In this repo, I triggered the error by changing the pyproject.toml to something
like this:

[tool.poetry]
name = "some_other_repo"
version = "0.1.0"
description = ""
authors = ["Jonathan Rayner <[email protected]>"]
packages = [{ include = "some_other_repo"}]

[tool.poetry.dependencies]
python = "^3.10 <3.13"

pkg_1 = {git = "[email protected]:JonathanRayner/some_monorepo.git", subdirectory = "pkg_1" }
pkg_2 = {git = "[email protected]:gustavgransbo/some_monorepo.git", subdirectory = "pkg_2", tag="v2"}

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

[TheSven73]

Created a WIP #9723 feel free to have a look.