Don't swallow ImportError in temporary_directory() (#3037)

Fixes #3026 If the context wrapped by the temporary_directory() context manager raised ImportError (for example because distutils.util cannot be imported, #721 #1837), it would previously keep going, causing a RuntimeError from contextlib: RuntimeError: generator didn't stop after throw() Co-authored-by: Remi Rampin <[email protected]>
python-poetry · Oct 2, 2020 · a2d2937 · a2d2937
1 parent 8e3f3c2
commit a2d2937
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/get-poetry.py b/get-poetry.py
@@ -159,15 +159,15 @@ def colorize(style, text):
 def temporary_directory(*args, **kwargs):
     try:
         from tempfile import TemporaryDirectory
-
-        with TemporaryDirectory(*args, **kwargs) as name:
-            yield name
     except ImportError:
         name = tempfile.mkdtemp(*args, **kwargs)
 
         yield name
 
         shutil.rmtree(name)
+    else:
+        with TemporaryDirectory(*args, **kwargs) as name:
+            yield name
 
 
 def string_to_bool(value):