PyModule_AddObject fix for Python 3.10 #5194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5193
The first commit adds
python3 -c "from PIL import Image"
to .ci/test.sh - for whatever reason, this fails in Python 3.10, while our pytest command does not.The second commit replaces instances like
with
This is per the example in https://docs.python.org/3/c-api/module.html#c.PyModule_AddObject, which calls
Py_INCREF
beforePyModule_AddObject
.