-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict between README and CONFIGURATION #263
Comments
Thanks for opening an issue.
python-lsp-server/pylsp/config/config.py Line 53 in 98dc9c0
It is however not clear to me if python-lsp-server/pylsp/config/config.py Lines 50 to 60 in 98dc9c0
|
True but maybe there should be considering That is perhaps
|
Any further thoughts on this? |
I think the whole situation with Here me out. The So someone added custom code to read the settings in flake8 pylsp plugin and apply those settings to linted files. So now we have a The proper solution IMO would be to just make flake8 aware of the actual file path by using the (I might be missing something as I'm not a big user of flake8 but I was thinking about it yesterday) |
Thanks for analyzing the situation in depth @rchl. Could you create a pull request that implements your proposed solution? |
Maybe I'd do that if I had more time but would still not be sure what extent of changes is expected here. Whether removing the |
If it's not really necessary, then I'm +1 with doing that. |
The README states when configuring flake8 one must
However, the CONFIGURATION suggests the value is either
["pycodestyle"]
or["pyflakes"]
.Which document is correct? I set it to
["flake8"]
and it seems to work. Thanks for your time.The text was updated successfully, but these errors were encountered: