Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python missing from LSP servers when using jupyterlab-lsp #17

Closed
maresb opened this issue Apr 24, 2021 · 2 comments
Closed

Python missing from LSP servers when using jupyterlab-lsp #17

maresb opened this issue Apr 24, 2021 · 2 comments

Comments

@maresb
Copy link

maresb commented Apr 24, 2021

Hi, I'm very excited to see development moving forward here!

I'm trying to get this running in my Dockerized development environment. I used mamba to install python-lsp-jsonrpc 1.0.0, python-lsp-server 1.0.1, and jupyterlab-lsp 3.5.0 from conda-forge. I can successfully run pylsp from the command line. However, it does not seem to be recognized by jupyterlab-lsp.

In contrast, palantir/python-language-server is recognized automatically by jupyterlab-lsp. Is some additional configuration expected/necessary? Thanks!

image

@krassowski
Copy link
Contributor

jupyterlab-lsp does not autodetect pylsp yet. We basically need to copy-paste https://github.com/krassowski/jupyterlab-lsp/blob/master/python_packages/jupyter_lsp/jupyter_lsp/specs/pyls.py as python_lsp_server.py and change pyls references to python-lsp-server. Feel free to open a PR.

@ccordoba12
Copy link
Member

Closing because this is an issue with jupyterlab-lsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants