Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename init_shared_memory to prepare_memory #24

Closed
pietroalbini opened this issue Feb 18, 2016 · 1 comment
Closed

Rename init_shared_memory to prepare_memory #24

pietroalbini opened this issue Feb 18, 2016 · 1 comment
Labels
C-api E-breaking
Milestone
botogram 0.2

Comments

@pietroalbini
Copy link
Contributor

I don't like so much the @bot.init_shared_memory/add_shared_memory_initializer names: they're too long and a bit ugly. I think a better naming is the following one:

  • @bot.init_shared_memory › @bot.prepare_memory
  • self.add_shared_memory_initializer › self.add_memory_preparer

This is a breaking change, but the old syntax will continue to work until 1.0.
@pietroalbini
Copy link
Contributor Author

Landed on master.

@pietroalbini pietroalbini mentioned this issue Mar 22, 2016
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-api E-breaking
Milestone
botogram 0.2
Development

No branches or pull requests
1 participant
@pietroalbini