Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider inline type definitions or a stubs package #449

Closed
llchan opened this issue Sep 30, 2018 · 2 comments
Closed

Consider inline type definitions or a stubs package #449

llchan opened this issue Sep 30, 2018 · 2 comments

Comments

@llchan
Copy link

llchan commented Sep 30, 2018

With the 18.2.0 release, a few new arguments were added to e.g. attr.s, and those are not reflected in the typeshed repo yet. The stance in the typeshed repo is to avoid version-specific signatures (see python/typeshed#153), but rather to defer that to inline pyi files in the package itself or stub packages (see PEP 561).

Would we be open to including attrs type definitions in pyi files here? If not, perhaps we could package them into a attrs-stubs package? Either way, I think it would be beneficial to include the files in this repo so that the changes are version controlled together.

@hynek
Copy link
Member

hynek commented Sep 30, 2018

Attrs does that already as of 18.2?

@llchan
Copy link
Author

llchan commented Oct 1, 2018

Yikes, now I feel silly. My apologies for now looking first! I searched for an attrs-stubs package but didnt look in site-packages for the pyi. Must be something with my mypy setup, I'll debug on my own. Sorry for the spam!

@llchan llchan closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants