-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17.1.0 breaks passing default
to Attribute
by keyword
#194
Comments
Hm, I think this can be reverted. |
I pushed a fix for this into #193. |
In our defense, the docs excplitly says you should never instantiate it yourself. :-| But yeah we'll fix it. |
Please don't make me read a big pile of docs just to find out that |
Serious question: how do you designate something to be public to read/inspect but private to create/write in an other way than docs? |
Make the constructor private. So, for example, have |
fixed in #193 |
txaws has some code that constructs
Attribute
directly (it is public, after all). It does so by passing a value for the default parameter by keyword (it is public, after all).https://github.com/twisted/txaws/blob/8127b45978aa7b91e65eae15546a63440932b57f/txaws/client/_validators.py#L46-L54
This worked prior to 17.1.0 but no longer does.
The text was updated successfully, but these errors were encountered: