Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun failed tests broken in 5.4.3 #7508

Closed
throwable-one opened this issue Jul 17, 2020 · 3 comments
Closed

Rerun failed tests broken in 5.4.3 #7508

throwable-one opened this issue Jul 17, 2020 · 3 comments
Labels
type: regression indicates a problem that was introduced in a release which was working previously

Comments

@throwable-one
Copy link

from unittest import TestCase


def test_test():
    assert False


class FooTest(TestCase):
    def test_test(self):
        self.fail()

Run pytest. Two tests should fail. Run with --last-failed. Only one test launched.
Try latest 5.3: it works as expected

@The-Compiler
Copy link
Member

Bisected to 1b30514 ("LFPlugin: use sub-plugins to deselect during collection (#6448)") which is a fix for #5301 - cc @blueyed

@blueyed
Copy link
Contributor

blueyed commented Jul 17, 2020

Likely fixed by #6991, was not backported (#7219).

@Zac-HD Zac-HD added the type: regression indicates a problem that was introduced in a release which was working previously label Jul 19, 2020
@The-Compiler
Copy link
Member

Indeed fixed via #6991 in master already - sorry, I missed that! Closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression indicates a problem that was introduced in a release which was working previously
Projects
None yet
Development

No branches or pull requests

4 participants