Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow config/session in from_parent api #6341

Closed
RonnyPfannschmidt opened this issue Dec 13, 2019 · 1 comment
Closed

disallow config/session in from_parent api #6341

RonnyPfannschmidt opened this issue Dec 13, 2019 · 1 comment
Assignees
@RonnyPfannschmidt
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog
Milestone
5.4

Comments

@RonnyPfannschmidt
Copy link
Member

one important part of the from_parent api is to streamline the node-tree structure and constructors
as such we need to disallow session/config as parameters, so they can be fetched from the parent object in all cases
@RonnyPfannschmidt RonnyPfannschmidt added the type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog label Dec 13, 2019
@RonnyPfannschmidt RonnyPfannschmidt added this to the 5.4 milestone Dec 13, 2019
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Dec 13, 2019
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Dec 31, 2019
@RonnyPfannschmidt
fix pytest-dev#6341 - disallow session/config in Node.from_parent
fdcd45f
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Dec 31, 2019
Merged
1 task
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Dec 31, 2019
@RonnyPfannschmidt
fix pytest-dev#6341 - disallow session/config in Node.from_parent
4fcacde
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jan 15, 2020
@RonnyPfannschmidt
fix pytest-dev#6341 - disallow session/config in Node.from_parent
2958129
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jan 15, 2020
@RonnyPfannschmidt
fix pytest-dev#6341 - disallow session/config in Node.from_parent
a852ba7
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jan 15, 2020
@RonnyPfannschmidt
fix pytest-dev#6341 - disallow session/config in Node.from_parent
8ba0b7b
@RonnyPfannschmidt
Copy link
Member Author

fixed in the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog
Projects
detangle node structure
Status: Done
Milestone
5.4
Development

No branches or pull requests
1 participant
@RonnyPfannschmidt