Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit relation between marks and keywords #4569

Open
RonnyPfannschmidt opened this issue Dec 20, 2018 · 4 comments
Open

revisit relation between marks and keywords #4569

RonnyPfannschmidt opened this issue Dec 20, 2018 · 4 comments
Labels
topic: marks related to marks, either the general marks or builtin type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

followup to #4564

classically marks where turned into keywords, by simply dumping the __dict__ of a function into a nodes keyword, implying the now removed MarkInfo objects landing in the keyword mapping

to ensure keywords keep working as they used to, i decided to add all mark names that where not already known keywords to the keywords of a node

but thats a pretty horrible hack and should be sorted out in a more principled manner

@nicoddemus nicoddemus added type: refactoring internal improvements to the code topic: marks related to marks, either the general marks or builtin labels Dec 20, 2018
@rajibmitra
Copy link

rajibmitra commented Jan 15, 2019

Is anyone working on this issue ? If not , I would like to work on this .

@RonnyPfannschmidt
Copy link
Member Author

@rajibmitra currently nobody is working on this one, but i also believe this one is one of the harder ones because its one of those things where a simple cleanup may break downstream users in subtle manners thats not expressed by our own testsuite

@rajibmitra
Copy link

so can you please point me to any simple issues @RonnyPfannschmidt

@RonnyPfannschmidt
Copy link
Member Author

@rajibmitra we have https://github.com/pytest-dev/pytest/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+easy%22 set up to get started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: marks related to marks, either the general marks or builtin type: refactoring internal improvements to the code
Projects
None yet
Development

No branches or pull requests

3 participants