Finalizers in the scope stack will not be executed if one finalizer raises an exception

[sangongs]

When one finalizer raises an exception, the finalizers remain in the scope stack will be skipped.

Test case:

    def test_teardown_multiple_scopes_one_fails(self, testdir):
        module_teardown = []
        def fin_func():
            raise Exception("oops1")
        def fin_module():
            module_teardown.append("fin_module")
        item = testdir.getitem("def test_func(): pass")
        ss = runner.SetupState()
        ss.addfinalizer(fin_module, item.listchain()[-2])
        ss.addfinalizer(fin_func, item)
        ss.prepare(item)
        with pytest.raises(Exception) as err:
            ss.teardown_exact(item, None)
        assert module_teardown

[pytestbot]

GitMate.io thinks possibly related issues are #2508 (Recommended fixture yield implementation doesn't execute teardown if setup raises exception), #709 (monkeypatch.setattr raises awkard exception), #287 (Fixture finalizer failure causes other finalizers to not be run), #2440 (Exception in SubRequest finalizer prevents further registered SubRequest finalizer calls), and #333 (INTERNALERROR when raising exception from pytest_runtest_call() after failed tests).

[nicoddemus]

Fixed by #3570. Thanks again @sangongs!