pexpect using tests regulary hang/die

[RonnyPfannschmidt]

we pretty much have broken tests there,
whenever i have pexpect installed, py.test hangs testing terminal or pdb

[RonnyPfannschmidt]

i keep hitting this one, i'm tempted to just remove pexpect since its all broken atm

[nicoddemus]

That doesn't happen on CI though does it?

[RonnyPfannschmidt]

yes, which makes it even more of a pain, since ithappens in tox/local usage and its typically due to badly set timeouts/interactions in each test

[nicoddemus]

In this case I would think twice about removing it, specially if we can't pin point the actual cause and it currently passes on CI.

[RonnyPfannschmidt]

what value does a test have, where we dont know why it works when it works

[nicoddemus]

I thought the pexpect tests ensured that user interaction work as expected in situations like --pdb. I never took a deeper look at them though.

[RonnyPfannschmidt]

@nicoddemus all i know that they regularly fall apart for me - and its starting to be really irritating

[srinivasreddy]

I can confirm this on my local.

[stanislavlevin]

ping

[RonnyPfannschmidt]

it wont pong, its hanging

[blueyed]

Is this still happening for you?

I've noticed "hacks" / code for Mac OS, but are you all using MacOS for when it happens/hangs?
(never seen it myself on Linux)

[blueyed]

So if you're seeing this, please use -vv to see the test that hangs.. see #3116 for a possible fix in this regard.

[nicoddemus]

Closing as no more information has been provided. We can reopen once the suggestion by @blueyed has been tried. 👍

[blueyed]

Turns out you have to read() with pending output before wait() - likely related to different behavior with regard to output buffering then maybe, but #5313 should fix it.