-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional_skip_names are not respected everywhere in pathlib #1023
Comments
I would probably implement it by checking the call stack too, as the final solution. Do you have a scenario in head for which checking call stack would cause trouble/unexpected behavior. |
Probably not. I just didn't like it much, but you may be right. |
I had that (using the callstack) in mind to use for all functions, but thought that there should be a better way. But as I wrote, this didn't work out. So, you are probably right that this is the way to go - I was just reluctant as I find it somewhat hacky. And with the callstack, you could just do it a single place, so it would probably be ok.
So, you are going to make another PR? Would be awesome! |
I will try. |
Describe the bug
Path().exists
andPath().unlink
for example don't work well withadditional_skip_names
.Context: #1021 (comment)
The text was updated successfully, but these errors were encountered: