Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support read/write of additional INP sections #217

Closed
kaklise opened this issue Mar 5, 2024 · 1 comment · Fixed by #219
Closed

Updates to support read/write of additional INP sections #217

kaklise opened this issue Mar 5, 2024 · 1 comment · Fixed by #219

Comments

@kaklise
Copy link
Contributor

kaklise commented Mar 5, 2024

I have been using swmmio to add stormwater/wastewater analysis to WNTR. The ability to read, modify, and write INP files using pandas DataFrames has been very helpful! I found a few issues when comparing simulation results with and without the read/write of INP files ([XSECTIONS], [INFLOWS], and [CURVES]). I also needed to support a few additional sections in Model.inp ([CONTROLS] and [PATTERNS]). I stored controls and patterns in DataFrames with 1 line per entry. I'm using INP files from SWMM and swmmio to test functionality. Let me know if you're interested in a PR!

@aerispaha
Copy link
Member

@kaklise, I'm so happy that swmmio has been helpful for you. 100% we're interested in a PR! Please feel free to submit a PR at your convenience, then we can continue the conversation there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants