Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff/Black code linting style enforcement to CI build tests #177

Open
aerispaha opened this issue Jan 4, 2023 · 2 comments
Open

Add Ruff/Black code linting style enforcement to CI build tests #177

aerispaha opened this issue Jan 4, 2023 · 2 comments

Comments

@aerispaha
Copy link
Member

aerispaha commented Jan 4, 2023

I propose we use Ruff for linting.

@bemcdonnell
Copy link
Member

@aerispaha, i think most people are moving to “black”

@aerispaha
Copy link
Member Author

@bemcdonnell I'm cool with using Black. However, my preference is to use Ruff for linting and formatting since I'm more familiar with it and I know that it's super fast (apparently 10-100x faster). Additionally, Ruff's formatter results in nearly identical results as Black (see the Ruff docs) about this.

Regardless, I think the more important thing is to agree on a reasonable set of code style standards. I tend to like using the Black/Ruff defaults with a handful of exceptions, which can be configured in the pyproject.toml.

@aerispaha aerispaha changed the title Add pep8 or similar code style enforment to CI build tests Add pep8 or similar code style enforcement to CI build tests Jan 13, 2025
@aerispaha aerispaha changed the title Add pep8 or similar code style enforcement to CI build tests Add Ruff/Black code linting style enforcement to CI build tests Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants