chore: move auth vars to index page #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petethepig
approved these changes
Mar 31, 2022
petethepig
added a commit
that referenced
this pull request
Apr 15, 2022
* chore(frontend): Added initial test structure for auth tests * feat(frontend): new tests on settings page * fix(frontend): fixed e2e path for cypress tests * fix(frontend): yarn.lock sry :( * feat(frontend): added e2e on user login & auth * chore(e2e): fixed tests path * chore(e2e): Unquote server args * fix(e2e): fix for multiple arguments for server launch * fix(e2e): changed cypress invocation in accordance with new server params * feat: make /login and /signup routes to be served with PWA * ref(frontend) add login page basic layout * ref(frontend) add signup page, intro pages styling * ref(frontend) add not found and forbidden pages * chore(webapp): move intro pages colors to global variables * feat(frontend): add log in page functionality * feat(frontend): add sign up page functionality * feat(webapp): add log in page external auth links * fix(webapp): fix redirect condition typo * chore(webapp): move intro pages; refactor login/signup styles and service methods * chore(webapp): change InputField style prop naming * chore(webapp): fix event and prop types * chore(webapp): add error typing, refactor inputfield styles application * chore(webapp): refactor inputField styles application * chore: ignore indexHandler cognitive complexity * Feat: move login to react (#985) * feat: make /login and /signup routes to be served with PWA * ref(frontend) add login page basic layout * ref(frontend) add signup page, intro pages styling * ref(frontend) add not found and forbidden pages * chore(webapp): move intro pages colors to global variables * feat(frontend): add log in page functionality * feat(frontend): add sign up page functionality * feat(webapp): add log in page external auth links * fix(webapp): fix redirect condition typo * chore(webapp): move intro pages; refactor login/signup styles and service methods * chore(webapp): change InputField style prop naming * chore(webapp): fix event and prop types * chore(webapp): add error typing, refactor inputfield styles application * chore(webapp): refactor inputField styles application * chore: ignore indexHandler cognitive complexity Co-authored-by: Antony Shaleynikov <[email protected]> * fix(webapp): change imports * feat: updated e2e tests in accordance with API changes * fix: fixed popup error on login screen * chore: move auth vars to index page (#991) * chore: move auth vars to index page * chore: auth vars objects * feat: added 404 handler to render template page * fix: eliminate possible merge issues * fix: resolve linting error * fix: more old merge issues * fix: fixing auth e2e and merge issues * fix: removed complexity error on go lint * feat: Added 404 handling on react side * fix: commiting index handlers on 404 * fix: fixing e2e tests * fix: added baseURL support * fix: fixed broken sidebar * fix: added features to index renderer * fix: forgotten lockfile * fix: update broken run-p on mac * fix: Maybe(fix) of e2e race condition * fix: maybe(fix) fixing exception while data isn't yet populated to flamegraph * fix: maybe(fix) of e2e test * fix: another possible fix for race condition * fix: revert previous fix * chore: hide sidebar on intro pages * chore: adjust oAuth buttons logic/styles on login * feat: added is signup enabled feature in server * chore: handle if signup enabled on login page * chore: adjust horizontal scroll on intro pages * fix: sidebar visibility on settings routes * fix: no user on Settings * chore: adjust signup/login pages user redirect * covers more cases, e.g when internal auth enabled but sign up disabled, etc * lint fix? * lint fix? * base url fixes * improvements * fixes * updates styling a bit * fix * fix(maybe): highlight cy test Co-authored-by: Antony Shaleynikov <[email protected]> Co-authored-by: Egor Mozheiko <[email protected]> Co-authored-by: EgorMozheiko <[email protected]> Co-authored-by: Anton Kolesnikov <[email protected]> Co-authored-by: pavelpashkovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #947 (comment). Note that
window.isAuthRequiredvariable is moved towindow.auth.isRequired./cc @EgorMozheiko