feat: add debug storage export endpoint #752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is aimed at improving debuggability. In order to solve issues like #715 more efficiently we need an option to export data from the storage in a user-friendly way. We extend our
/debug
endpoints list with/debug/storage/export/{db}
that exports values from the storage via HTTP.Example:
The request will write
s:pyroscope.server.cpu{}
segment raw bytes to /tmp/segment.NOTE: We have set 15 seconds HTTP server timeout, and it is not configurable. I'm wondering if this should be lifted - say, a minute, or two.