Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/keep existing colors when highlighting #714

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Jan 12, 2022

Closes #700

image

image

Also fixes the jest snapshot tests, which were not working properly.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 341.47 KB (+0.01% 🔺) 6.9 s (+0.01% 🔺) 974 ms (+0.08% 🔺) 7.9 s

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #714 (98dd355) into main (9a4d655) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   76.62%   76.61%   -0.01%     
==========================================
  Files          60       60              
  Lines        2070     2069       -1     
  Branches      371      371              
==========================================
- Hits         1586     1585       -1     
  Misses        456      456              
  Partials       28       28              
Impacted Files Coverage Δ
...lameGraph/FlameGraphComponent/Flamegraph_render.ts 96.95% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4d655...98dd355. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Jan 12, 2022

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Result

main pr diff threshold
throughput 214.11 213.67 -0.44 (-0.21%) 5%
total items processed 65215.00 64500.00 -715.00 (-1.10%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}

Generated by 🚫 dangerJS against 728cc37

@petethepig petethepig merged commit ab094c2 into main Jan 13, 2022
@petethepig petethepig deleted the feat/keep-existing-colors-when-highlighting branch January 13, 2022 00:34
juliosaraiva pushed a commit to juliosaraiva/pyroscope that referenced this pull request Jan 16, 2022
* feat(frontend): render original color when highlighted

* generate new jest snapshots and fix test to check those snapshots

* update cypress snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep existing colors when highlighting in diff page
3 participants