-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sidebar links #489
Make sidebar links #489
Conversation
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 55.26% 56.06% +0.80%
==========================================
Files 163 164 +1
Lines 6868 6990 +122
Branches 169 196 +27
==========================================
+ Hits 3795 3918 +123
+ Misses 2758 2755 -3
- Partials 315 317 +2
Continue to review full report at Codecov.
|
30d9b4a
to
c95b452
Compare
@eh-am can I get a review for this one too? |
@clovis1122 Thank you again! Hmm, weird, now the query params aren't being passed between different pages: |
@eh-am whoops! Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Added few suggestions, super minor, but overall looks great!
Co-authored-by: eduardo aleixo <[email protected]>
Co-authored-by: eduardo aleixo <[email protected]>
Thanks, done! |
This is awesome thanks @clovis1122 !!! |
* Update jpprof to 0.1.6 * Fix gradle problem with snapshot
This PR uses the NavLink component on the sidebar to make these act as links. Because the history state is now managed by a 3rd party, we can safely remove the previous test as well (otherwise we would be basically testing the 3rd party library...).
closes #305