-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/441 "focus on this subtree" #480
Conversation
Nice work! Looks awesome so far... I think for the text "Focus on this node" is less clear than "collapse" or "collapse above". Mostly because focus is a little more broad in that it could be interpreted multiple different ways in this context whereas collapse is a specific kind of focus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Everything seems to be running pretty smoothly and couldn't find any edge cases thanks for adding the double-click functionality too!
@Rperry2174 Great ideas! Let me merge this and do that work in a separate PR. |
This PR introduces new functionality called
focus on this subtree
, based on #4411 - It allows to change the flamegraph root:
Currently the state is tored locally, but in the future people could use to share a specific subtree.
2 - It still allows zooming
3 - Clicking on the same node undoes the zoom:
4 - You can mix and match zoom/focus, here for example we zoom and then we focus:
This currently is scoped under a
contextmenu
event, up next this feature would be available under a toolbar as well.