Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection #425

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix intersection #425

merged 1 commit into from
Sep 29, 2021

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Sep 29, 2021

Although the new implementation is pretty expensive, it should not be an issue given that it is still in order of microseconds (and will never be the main factor of querying performance). I also think we should migrate to bitmaps for better set operations.

@kolesnikovae kolesnikovae self-assigned this Sep 29, 2021
@kolesnikovae kolesnikovae added the type/bug Something isn't working label Sep 29, 2021
@github-actions github-actions bot requested a review from Rperry2174 September 29, 2021 12:51
@kolesnikovae kolesnikovae added the storage Low level storage matters label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #425 (5157bb2) into main (6eb4a6c) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   51.62%   51.40%   -0.22%     
==========================================
  Files         125      125              
  Lines        5713     5695      -18     
==========================================
- Hits         2949     2927      -22     
- Misses       2478     2482       +4     
  Partials      286      286              
Impacted Files Coverage Δ
pkg/storage/dimension/dimension.go 45.72% <100.00%> (-15.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb4a6c...5157bb2. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 155.91 155.63 -0.28 (-0.18%) 5%
total items processed 130386.00 130807.00 421.00 (0.32%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against a9be078

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Anton!

@petethepig petethepig merged commit bf34937 into main Sep 29, 2021
@petethepig petethepig deleted the fix-dimension-intersection branch September 29, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage Low level storage matters type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants