Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an "Updates Available" label to the footer #333

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

petethepig
Copy link
Member

This is what it looks like rn

Screen Shot 2021-08-11 at 12 45 04 AM

@github-actions github-actions bot requested a review from Rperry2174 August 11, 2021 07:45
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #333 (0c89ea5) into main (bc34086) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   53.97%   53.95%   -0.02%     
==========================================
  Files         102      102              
  Lines        4777     4779       +2     
==========================================
  Hits         2578     2578              
- Misses       1960     1962       +2     
  Partials      239      239              
Impacted Files Coverage Δ
pkg/server/controller.go 31.64% <0.00%> (-0.16%) ⬇️
pkg/server/handler.go 0.44% <0.00%> (-<0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32a38b...0c89ea5. Read the comment docs.

Copy link
Contributor

@yashrsharma44 yashrsharma44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, especially the goroutine that runs for 24 hours, and fetches the version. 💪

@petethepig
Copy link
Member Author

Thanks @yashrsharma44 !

@petethepig petethepig merged commit 4923be0 into main Aug 13, 2021
@petethepig petethepig deleted the update-notice branch August 13, 2021 01:02
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
* Edit the go instrumentation documentation

* Fixes fgprof link

* Review feedbakc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants